ChinmaySKulkarni commented on a change in pull request #494: PHOENIX-5262 Wrong
Result on Salted table with Varbinary PK
URL: https://github.com/apache/phoenix/pull/494#discussion_r279581843
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java
##########
@@ -194,7 +194,8 @@ public void testSingleVariableFullPkSalted() throws
SQLException {
PVarchar.INSTANCE.toBytes("a", key, 1);
key[0] = SaltingUtil.getSaltingByte(key, 1, 1, 20);
byte[] expectedStartKey = key;
- byte[] expectedEndKey = ByteUtil.nextKey(ByteUtil.concat(key,
QueryConstants.SEPARATOR_BYTE_ARRAY));
+ //lexigraphically this is the next PK
Review comment:
nit: lexicographically
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
