[
https://issues.apache.org/jira/browse/PHOENIX-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884589#comment-16884589
]
Hadoop QA commented on PHOENIX-4893:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12974623/PHOENIX-4893-4.x-HBase-1.3-v3.patch
against 4.x-HBase-1.3 branch at commit
3c5edd6fab97ccc09ec9e93b8c839f8a076ca891.
ATTACHMENT ID: 12974623
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ (PName) isNull(), eq(new byte[0]),
eq(Bytes.toBytes(viewName)), anyLong(), anyLong());
+ any(PTable.class), anyMap(),
anySetOf(String.class), anyListOf(PColumn.class));
+ ViewUtil.findAllRelatives(getTable(linkTable),
HConstants.EMPTY_BYTE_ARRAY, table.getSchemaName().getBytes(),
+ TaskRegionEnvironment,
QueryServicesOptions.DEFAULT_TASK_HANDLING_MAX_INTERVAL_MS);
+
assertEquals(SQLExceptionCode.CANNOT_DROP_VIEW_REFERENCED_COL.getErrorCode(),
e.getErrorCode());
+
assertEquals(SQLExceptionCode.CANNOT_DROP_VIEW_REFERENCED_COL.getErrorCode(),
e.getErrorCode());
+
assertEquals(SQLExceptionCode.CANNOT_DROP_VIEW_REFERENCED_COL.getErrorCode(),
e.getErrorCode());
+ * Validates that we can add the column to the base table by ensuring that
if the same column already
+ public MetaDataProtocol.MetaDataMutationResult
validateWithChildViews(PTable table, List<PTable> childViews,
+
List<Mutation> tableMetadata,
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewMetadataIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexUsageIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificTablesDDLIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PropertiesInSyncIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.DropColumnIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.rpc.UpdateCacheIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2784//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2784//console
This message is automatically generated.
> Move parent column combining logic of view and view indexes from server to
> client
> ---------------------------------------------------------------------------------
>
> Key: PHOENIX-4893
> URL: https://issues.apache.org/jira/browse/PHOENIX-4893
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Lars Hofhansl
> Assignee: Thomas D'Silva
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4893-4.x-HBase-1.3-v1.patch,
> PHOENIX-4893-4.x-HBase-1.3-v2.patch, PHOENIX-4893-4.x-HBase-1.3-v3.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In a stack trace I see that phoenix.coprocessor.ViewFinder.findRelatedViews()
> scans SYSCAT. With splittable SYSCAT which now involves regions from other
> servers.
> We should really push this to the client now.
> Related to HBASE-21166
> [~tdsilva]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
