[
https://issues.apache.org/jira/browse/PHOENIX-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885725#comment-16885725
]
Hadoop QA commented on PHOENIX-4893:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12974775/PHOENIX-4893-4.x-HBase-1.3-v6.patch
against 4.x-HBase-1.3 branch at commit
8c82572fd08d9208aff10c1e666cbdf34e492410.
ATTACHMENT ID: 12974775
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // we need to take into account the columns
inherited from the base table
+
PColumnImpl.createExcludedColumn(MetaDataEndpointImpl.newPName(familyName),
+ MetaDataProtocol.MetaDataMutationResult validateWithChildViews(PTable
table, List<PTable> childViews,
+ byte[]
schemaName, byte[] tableName)
+ MetaDataProtocol.MetaDataMutationResult validateAndAddMetadata(PTable
table, byte[][] rowKeyMetaData,
+
List<Mutation> tableMetadata, Region region,
+
List<ImmutableBytesPtr> invalidateList,
+ * @return list of pair of table and column being dropped, used to drop
any indexes that require the column
+ private static final byte[] CHILD_TABLE_BYTES = new
byte[]{PTable.LinkType.CHILD_TABLE.getSerializedValue()};
+ this.allowSplittableSystemCatalogRollback =
config.getBoolean(QueryServices.ALLOW_SPLITTABLE_SYSTEM_CATALOG_ROLLBACK,
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2792//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2792//console
This message is automatically generated.
> Move parent column combining logic of view and view indexes from server to
> client
> ---------------------------------------------------------------------------------
>
> Key: PHOENIX-4893
> URL: https://issues.apache.org/jira/browse/PHOENIX-4893
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Lars Hofhansl
> Assignee: Thomas D'Silva
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4893-4.x-HBase-1.3-v1.patch,
> PHOENIX-4893-4.x-HBase-1.3-v2.patch, PHOENIX-4893-4.x-HBase-1.3-v3.patch,
> PHOENIX-4893-4.x-HBase-1.3-v4.patch, PHOENIX-4893-4.x-HBase-1.3-v5.patch,
> PHOENIX-4893-4.x-HBase-1.3-v6.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In a stack trace I see that phoenix.coprocessor.ViewFinder.findRelatedViews()
> scans SYSCAT. With splittable SYSCAT which now involves regions from other
> servers.
> We should really push this to the client now.
> Related to HBASE-21166
> [~tdsilva]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
