ChinmaySKulkarni commented on a change in pull request #550: PHOENIX-5348: Fix
flaky test: testIndexRebuildTask
URL: https://github.com/apache/phoenix/pull/550#discussion_r309032177
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexRebuildTaskIT.java
##########
@@ -188,7 +185,17 @@ public static void waitForTaskState(Connection conn,
PTable.TaskType taskType, P
String taskStatus = null;
- if (rs.next()) {
+ while (rs.next()) {
+ String tableName =
rs.getString(PhoenixDatabaseMetaData.TABLE_NAME);
+ if (!tableName.equals(expectedTableName)) {
Review comment:
+1 to that. I think that would also not require us to have the `continue`
statements in case there are no matches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services