ChinmaySKulkarni commented on a change in pull request #550: PHOENIX-5348: Fix
flaky test: testIndexRebuildTask
URL: https://github.com/apache/phoenix/pull/550#discussion_r312656841
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/tasks/IndexRebuildTask.java
##########
@@ -107,6 +107,7 @@
Task.addTask(conn.unwrap(PhoenixConnection.class ),
taskRecord.getTaskType(), taskRecord.getTenantId(), taskRecord.getSchemaName(),
taskRecord.getTableName(),
PTable.TaskStatus.STARTED.toString(), jsonObject.toString(),
taskRecord.getPriority(),
taskRecord.getTimeStamp(), null, true);
+ conn.commit();
Review comment:
@gokceni what are we committing here? Also, this change seems outside the
scope of this JIRA again. Is there any change you made which would now require
a `conn.commit` after adding a task?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
