ChinmaySKulkarni commented on a change in pull request #550: PHOENIX-5348: Fix 
flaky test: testIndexRebuildTask
URL: https://github.com/apache/phoenix/pull/550#discussion_r312656695
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
 ##########
 @@ -255,6 +257,7 @@ public static void setEndTaskStatus(PhoenixConnection 
connForTask, Task.TaskReco
             Task.addTask(connForTask, taskRecord.getTaskType(), 
taskRecord.getTenantId(), taskRecord.getSchemaName(),
                     taskRecord.getTableName(), taskStatus, data, 
taskRecord.getPriority(),
                     taskRecord.getTimeStamp(), endTs, true);
+            connForTask.commit();
 
 Review comment:
   Also, this and the previous change in this file seem outside the scope of 
this JIRA which is just to fix the flaky test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to