lhofhansl commented on a change in pull request #629: PHOENIX-5559 Fix
remaining issues with Long viewIndexIds.
URL: https://github.com/apache/phoenix/pull/629#discussion_r345449980
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -2082,7 +2082,7 @@ private long getViewIndexSequenceValue(PhoenixConnection
connection, String tena
long sequenceTimestamp = HConstants.LATEST_TIMESTAMP;
try {
connection.getQueryServices().createSequence(key.getTenantId(),
key.getSchemaName(), key.getSequenceName(),
- Long.MIN_VALUE, 1, 1, Long.MIN_VALUE, Long.MAX_VALUE,
false, sequenceTimestamp);
+ Short.MIN_VALUE, 1, 1, Long.MIN_VALUE, Long.MAX_VALUE,
false, sequenceTimestamp);
Review comment:
This is the core change. In order to work with both short and long view
index ids, we start with Short.MIN_VALUE, which can be encoded both as short
and long.
The bulk of the rest are test fixes for tests that happen to verify the
generate index id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
