lhofhansl commented on a change in pull request #629: PHOENIX-5559 Fix
remaining issues with Long viewIndexIds.
URL: https://github.com/apache/phoenix/pull/629#discussion_r345537662
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseTenantSpecificViewIndexIT.java
##########
@@ -148,10 +148,10 @@ private void createAndVerifyIndex(Connection conn,
String viewName, String table
+ "CLIENT MERGE SORT",
QueryUtil.getExplainPlan(rs));
} else {
String expected = saltBuckets == null ?
- "CLIENT PARALLEL 1-WAY RANGE SCAN OVER _IDX_" + tableName
+ " [" + Long.toString(Long.MIN_VALUE + expectedIndexIdOffset) + ",'" +
tenantId + "','" + valuePrefix + "v2-1']\n"
+ "CLIENT PARALLEL 1-WAY RANGE SCAN OVER _IDX_" + tableName
+ " [" + Long.toString(Short.MIN_VALUE + expectedIndexIdOffset) + ",'" +
tenantId + "','" + valuePrefix + "v2-1']\n"
Review comment:
I mostly restore this part from before PHOENIX-3547.
Realizing now it was all over the place. Using + Short.MIN_VALUE is some
place, -32768 in others, toString in yet others.
Here it does not matter though, the output is identical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
