lhofhansl commented on a change in pull request #629: PHOENIX-5559 Fix
remaining issues with Long viewIndexIds.
URL: https://github.com/apache/phoenix/pull/629#discussion_r345528655
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
##########
@@ -178,8 +178,11 @@ private static void throwIfScanOutOfRegion(Scan scan,
Region region) throws DoNo
byte[] expectedUpperRegionKey =
scan.getAttribute(EXPECTED_UPPER_REGION_KEY) == null ?
scan.getStopRow() : scan
.getAttribute(EXPECTED_UPPER_REGION_KEY);
- isStaleRegionBoundaries = expectedUpperRegionKey != null &&
- Bytes.compareTo(upperExclusiveRegionKey,
expectedUpperRegionKey) != 0;
+
Review comment:
The main part I could use a double-check on... Did I understand the purpose
of SCAN_ACTUAL_START_ROW correctly?
From looking at the code and going by the name it's the start row of the
scan that we can use in Phoenix to restart the scan (and that can happen
exactly when a split occurred and the scanner was restarted by HBase with the
new region start key - assuming it fell into the second daughter region). If
that is indeed the right interpretation that this should be correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
