[
https://issues.apache.org/jira/browse/PHOENIX-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979813#comment-16979813
]
Hadoop QA commented on PHOENIX-5578:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12986472/PHOENIX-5578-4.14-HBase-1.3.patch
against 4.14-HBase-1.3 branch at commit
8f4cbf028585d3e017143e579d07369be384ff7d.
ATTACHMENT ID: 12986472
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ HTableDescriptor baseDescriptor =
admin.getTableDescriptor(TableName.valueOf(physicalTableName));
+ HTableDescriptor indexDescriptor =
admin.getTableDescriptor(TableName.valueOf(physicalIndexName));
+ TableName indexTable =
TableName.valueOf(SchemaUtil.getPhysicalHBaseTableName(schemaName,
+ private void removeCoproc(Class clazz, HTableDescriptor descriptor, Admin
admin) throws Exception {
+ conn.createStatement().execute("CREATE INDEX " + indexName + " ON " +
fullTableName + "(v1)");
+ private void createBaseTable(String schemaName, String tableName, boolean
multiTenant, Integer saltBuckets, String splits)
+ props.setProperty(QueryServices.IS_NAMESPACE_MAPPING_ENABLED,
Boolean.toString(isNamespaceMapped));
+
opts.put(NonTxIndexBuilder.CODEC_CLASS_NAME_KEY,
PhoenixIndexCodec.class.getName());
+ IndexRegionObserver.enableIndexing(descriptor,
PhoenixIndexBuilder.class, opts, priority);
+
opts.put(NonTxIndexBuilder.CODEC_CLASS_NAME_KEY,
PhoenixIndexCodec.class.getName());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexScrutinyToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.SaltedIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ParameterizedIndexUpgradeToolIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3149//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3149//console
This message is automatically generated.
> "CREATE TABLE IF NOT EXISTS " loads IndexRegionObserver on an existing table
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-5578
> URL: https://issues.apache.org/jira/browse/PHOENIX-5578
> Project: Phoenix
> Issue Type: Bug
> Reporter: Swaroopa Kadam
> Assignee: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-5578-4.14-HBase-1.3.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> # Table is already created with old design
> # new design is enabled
> # Execute "CREATE TABLE IF NOT EXISTS" for the same table
> # See that it loads IRO which shouldnt happen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
