[
https://issues.apache.org/jira/browse/PHOENIX-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996083#comment-16996083
]
Hadoop QA commented on PHOENIX-5578:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12988842/PHOENIX-5578.patch
against master branch at commit e7207b96402852440243a0d7d8c7c572cffcd322.
ATTACHMENT ID: 12988842
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ TableDescriptorBuilder indexDescBuilder =
TableDescriptorBuilder.newBuilder(indexDescriptor);
+ TableName indexTable =
TableName.valueOf(SchemaUtil.getPhysicalHBaseTableName(schemaName,
+ private void removeCoproc(Class clazz, TableDescriptorBuilder descBuilder,
Admin admin) throws Exception {
+ conn.createStatement().execute("CREATE INDEX " + indexName + " ON " +
fullTableName + "(v1)");
+ private void addColumnToBaseTable(String schemaName, String tableName,
String columnName) throws Exception{
+ private void dropColumnToBaseTable(String schemaName, String tableName,
String columnName) throws Exception{
+ private void createBaseTable(String schemaName, String tableName, boolean
multiTenant, Integer saltBuckets, String splits)
+ props.setProperty(QueryServices.IS_NAMESPACE_MAPPING_ENABLED,
Boolean.toString(isNamespaceMapped));
+
opts.put(NonTxIndexBuilder.CODEC_CLASS_NAME_KEY,
PhoenixIndexCodec.class.getName());
+ IndexRegionObserver.enableIndexing(builder,
PhoenixIndexBuilder.class, opts, priority);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PermissionsCacheIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tool.ParameterizedPhoenixCanaryToolIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3192//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3192//console
This message is automatically generated.
> "CREATE TABLE IF NOT EXISTS " loads IndexRegionObserver on an existing table
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-5578
> URL: https://issues.apache.org/jira/browse/PHOENIX-5578
> Project: Phoenix
> Issue Type: Bug
> Reporter: Swaroopa Kadam
> Assignee: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-5578-4.14-HBase-1.3.patch,
> PHOENIX-5578-4.14-HBase-1.3.v2.patch, PHOENIX-5578-4.x-HBase-1.5.patch,
> PHOENIX-5578.patch
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> # Table is already created with old design
> # new design is enabled
> # Execute "CREATE TABLE IF NOT EXISTS" for the same table
> # See that it loads IRO which shouldnt happen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
