[ 
https://issues.apache.org/jira/browse/PHOENIX-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984159#comment-16984159
 ] 

Lars Hofhansl commented on PHOENIX-5597:
----------------------------------------

Thanks for looking at this so quickly [~kozdemir].

Not ideal that this scenario was not covered by a test (Not blaming - 100% 
coverage is not possible for SQL. It's just that we've seen many blocking 
issues just in the last weeks for which an IT would have been possible to 
write).

I assume you test this case with this part of the change:
{code}
-            String selectSql = "SELECT val2, val3 from " + dataTableName + " 
WHERE val1  = 'ab'";
+            String selectSql = "SELECT val2, val3 from " + dataTableName + " 
WHERE val1  = 'ab' and val2 = 'abcc'";
{code}

Are there other scenarios that now go untested due to this change?


> No read repair happens when scans filter rows based on a covered column
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-5597
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5597
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 4.14.3
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Blocker
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-5597.4.x-HBase-1.5.001.patch, 
> PHOENIX-5597.master.001.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Assume that the schema for a data and index table is as follows:
> create table datatable (id varchar(10) not null primary key, val1 
> varchar(10), val2 varchar(10), val3 varchar(10))
> create index indextable on datatable (val1) include (val2, val3)
> A query that filters rows on a covered column does not trigger the index read 
> repair for unverified index rows. For example, the following query will not 
> trigger the read repair
> select val2, val3 from datatable WHERE val1 = 'ab' and val2 = 'abc'
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to