[
https://issues.apache.org/jira/browse/PHOENIX-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984204#comment-16984204
]
Hadoop QA commented on PHOENIX-5597:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12987033/PHOENIX-5597.4.x-HBase-1.5.001.patch
against 4.x-HBase-1.5 branch at commit
7e298b3b4b51e5ebfcd46cf0c9724fcf36cbd9fd.
ATTACHMENT ID: 12987033
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String selectSql = "SELECT val2, val3 from " + dataTableName +
" WHERE val1 = 'ab' and val2 = 'abcc'";
+ ((Put) m).addColumn(emptyCF, emptyCQ, timestamp,
IndexRegionObserver.UNVERIFIED_BYTES);
+ verifiedPut.addColumn(emptyCF, emptyCQ, timestamp,
IndexRegionObserver.VERIFIED_BYTES);
+ context.indexUpdates = ArrayListMultimap.<HTableInterfaceReference,
Pair<Mutation, byte[]>>create();
+ List <Pair<Mutation, byte[]>> updates =
context.indexUpdates.get(hTableInterfaceReference);
+ // This will be done before the data table row is
updated (i.e., in the first write phase)
+ // This will be done before the data table row is
updated (i.e., in the first write phase)
+ new HTableInterfaceReference(new
ImmutableBytesPtr(indexMaintainer.getIndexTableName()));
+ List <Pair<Mutation, byte[]>> updates =
context.indexUpdates.get(hTableInterfaceReference);
+ // We are done with handling concurrent mutations. So we can remove the
rows of this batch from
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3165//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3165//console
This message is automatically generated.
> No read repair happens when scans filter rows based on a covered column
> -----------------------------------------------------------------------
>
> Key: PHOENIX-5597
> URL: https://issues.apache.org/jira/browse/PHOENIX-5597
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Blocker
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5597.4.x-HBase-1.5.001.patch,
> PHOENIX-5597.master.001.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Assume that the schema for a data and index table is as follows:
> create table datatable (id varchar(10) not null primary key, val1
> varchar(10), val2 varchar(10), val3 varchar(10))
> create index indextable on datatable (val1) include (val2, val3)
> A query that filters rows on a covered column does not trigger the index read
> repair for unverified index rows. For example, the following query will not
> trigger the read repair
> select val2, val3 from datatable WHERE val1 = 'ab' and val2 = 'abc'
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
