[
https://issues.apache.org/jira/browse/PHOENIX-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984711#comment-16984711
]
Chinmay Kulkarni commented on PHOENIX-5597:
-------------------------------------------
I have left a couple of comments on the PR, otherwise overall the patch lgtm.
Thanks for the quick turnaround on this Kadir!
Another comment in general about the new indexing code: We suffer from a lack
of unit tests overall in Phoenix and a lot of this is due to code that cannot
be broken down into units (for ex: 1000 line methods). Due to this, we resort
to integration tests and hope that bugs get caught there.
Since this indexing code is relatively new, I think we should make it a point
to have testable units from the get-go and add UTs as much as possible. *Not in
the scope of this JIRA*, but perhaps we can have an improvement JIRA that goes
into 4.15.1/5.1.0 which refactors and adds improved test coverage for at least
all this new code, before it becomes unmanageable.
[~kozdemir] [~larsh] [~gjacoby] [~vincentpoon]
> No read repair happens when scans filter rows based on a covered column
> -----------------------------------------------------------------------
>
> Key: PHOENIX-5597
> URL: https://issues.apache.org/jira/browse/PHOENIX-5597
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Blocker
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5597.4.x-HBase-1.5.001.patch,
> PHOENIX-5597.master.001.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Assume that the schema for a data and index table is as follows:
> create table datatable (id varchar(10) not null primary key, val1
> varchar(10), val2 varchar(10), val3 varchar(10))
> create index indextable on datatable (val1) include (val2, val3)
> A query that filters rows on a covered column does not trigger the index read
> repair for unverified index rows. For example, the following query will not
> trigger the read repair
> select val2, val3 from datatable WHERE val1 = 'ab' and val2 = 'abc'
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
