[
https://issues.apache.org/jira/browse/PHOENIX-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009486#comment-17009486
]
Nitesh Maheshwari commented on PHOENIX-5654:
--------------------------------------------
> {color:#FF0000}-1 tests included{color}.
I have new tests and also updates some existing tests - not sure why a -1 here.
> {color:#FF0000}-1 core tests{color}. The patch failed these unit tests:
> ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.ChunkedResultIteratorIT
This failure seems unrelated to my change and the test passes when I run it
locally.
> String values (ALWAYS and NEVER) don't work for connection level config
> phoenix.default.update.cache.frequency
> --------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5654
> URL: https://issues.apache.org/jira/browse/PHOENIX-5654
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Nitesh Maheshwari
> Assignee: Nitesh Maheshwari
> Priority: Major
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5654.master.v1.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> While working on PHOENIX-5634, I noticed that the connection level property
> 'phoenix.default.update.cache.frequency' is being read in
> 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as
> follows:
> {code:java}
> long updateCacheFrequency = connection.getQueryServices().getProps().getLong(
> QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
> QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
> {code}
> However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' at
> [https://phoenix.apache.org/language/index.html], the value for this config
> could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above
> will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when
> the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property
> should also follow the way the table-level property is read in
> 'TableProperty.UPDATE_CACHE_FREQUENCY'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
