[
https://issues.apache.org/jira/browse/PHOENIX-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012337#comment-17012337
]
Chinmay Kulkarni commented on PHOENIX-5654:
-------------------------------------------
Thanks [~ntshmah]. Committed to master, 4.x and 4.15 branches. Can you please
close your PR? For some reason, I have lost write access to
github.com/apache/phoenix so can't do it myself. Also, I ammended your commit
message to only contain the JIRA title (See
[this|https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=fc22e99d7846ca342c5531b26ed6ff58cfa8f8e7])
and removed everything else. Please keep that in mind for your next
contribution, thanks!
> String values (ALWAYS and NEVER) don't work for connection level config
> phoenix.default.update.cache.frequency
> --------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5654
> URL: https://issues.apache.org/jira/browse/PHOENIX-5654
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Nitesh Maheshwari
> Assignee: Nitesh Maheshwari
> Priority: Major
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5654.4.x-HBase-1.3.v1.patch,
> PHOENIX-5654.4.x-HBase-1.3.v2.patch, PHOENIX-5654.4.x-HBase-1.3.v3.patch,
> PHOENIX-5654.master.v1.patch, PHOENIX-5654.master.v2.patch,
> PHOENIX-5654.master.v3.patch, PHOENIX-5654.master.v4.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> While working on PHOENIX-5634, I noticed that the connection level property
> 'phoenix.default.update.cache.frequency' is being read in
> 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as
> follows:
> {code:java}
> long updateCacheFrequency = connection.getQueryServices().getProps().getLong(
> QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
> QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
> {code}
> However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' atÂ
> [https://phoenix.apache.org/language/index.html], the value for this config
> could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above
> will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when
> the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property
> should also follow the way the table-level property is read in
> 'TableProperty.UPDATE_CACHE_FREQUENCY'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
