[
https://issues.apache.org/jira/browse/PHOENIX-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011385#comment-17011385
]
Hadoop QA commented on PHOENIX-5654:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12990363/PHOENIX-5654.master.v4.patch
against master branch at commit e6a5c7ae71c97d702ac3250e5886db92eccd8404.
ATTACHMENT ID: 12990363
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3258//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3258//console
This message is automatically generated.
> String values (ALWAYS and NEVER) don't work for connection level config
> phoenix.default.update.cache.frequency
> --------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5654
> URL: https://issues.apache.org/jira/browse/PHOENIX-5654
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Nitesh Maheshwari
> Assignee: Nitesh Maheshwari
> Priority: Major
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5654.4.x-HBase-1.3.v1.patch,
> PHOENIX-5654.master.v1.patch, PHOENIX-5654.master.v2.patch,
> PHOENIX-5654.master.v3.patch, PHOENIX-5654.master.v4.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> While working on PHOENIX-5634, I noticed that the connection level property
> 'phoenix.default.update.cache.frequency' is being read in
> 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as
> follows:
> {code:java}
> long updateCacheFrequency = connection.getQueryServices().getProps().getLong(
> QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
> QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
> {code}
> However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' atÂ
> [https://phoenix.apache.org/language/index.html], the value for this config
> could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above
> will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when
> the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property
> should also follow the way the table-level property is read in
> 'TableProperty.UPDATE_CACHE_FREQUENCY'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
