gjacoby126 commented on a change in pull request #679: PHOENIX-5645 -
BaseScannerRegionObserver should prevent compaction from purg…
URL: https://github.com/apache/phoenix/pull/679#discussion_r366671111
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java
##########
@@ -213,51 +274,57 @@ public void testRecentMaxVersionsNotCompactedAway()
throws Exception {
String thirdValue = "ghi";
try (Connection conn = DriverManager.getConnection(getUrl())) {
String dataTableName = generateUniqueName();
- String indexStem = generateUniqueName();
- createTableAndIndexes(conn, dataTableName, indexStem, versions);
- long afterInsertSCN =
org.apache.phoenix.util.EnvironmentEdgeManager.currentTimeMillis();
+ String indexName = generateUniqueName();
+ createTable(dataTableName);
+ //increment by 10 min to make sure we don't "look back" past table
creation
Review comment:
Thanks, good catch. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
