gjacoby126 commented on a change in pull request #679: PHOENIX-5645 -
BaseScannerRegionObserver should prevent compaction from purg…
URL: https://github.com/apache/phoenix/pull/679#discussion_r366626438
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java
##########
@@ -168,36 +184,48 @@ public void testTTLAndMaxLookbackAge() throws Exception {
conf.setLong(HRegion.MEMSTORE_PERIODIC_FLUSH_INTERVAL, 0L);
try (Connection conn = DriverManager.getConnection(getUrl())) {
String dataTableName = generateUniqueName();
- String indexStem = generateUniqueName();
- createTableAndIndexes(conn, dataTableName, indexStem);
- long afterFirstInsertSCN =
org.apache.phoenix.util.EnvironmentEdgeManager.currentTimeMillis();
+ createTable(dataTableName);
+ //increment by 10 min to make sure we don't "look back" past table
creation
Review comment:
WAIT_AFTER_TABLE_CREATION isn't meant to be a factor of MAX_LOOKBACK_AGE --
it's just an arbitrarily large number to make sure that all the metadata is
older than the current timestamp. It could probably be lower, but since the
size doesn't cost us anything I didn't spend too much time trying to optimize
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
