kadirozde commented on a change in pull request #679: PHOENIX-5645 -
BaseScannerRegionObserver should prevent compaction from purg…
URL: https://github.com/apache/phoenix/pull/679#discussion_r366627276
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java
##########
@@ -213,62 +241,49 @@ public void testRecentMaxVersionsNotCompactedAway()
throws Exception {
String thirdValue = "ghi";
try (Connection conn = DriverManager.getConnection(getUrl())) {
String dataTableName = generateUniqueName();
- String indexStem = generateUniqueName();
- createTableAndIndexes(conn, dataTableName, indexStem, versions);
- long afterInsertSCN =
org.apache.phoenix.util.EnvironmentEdgeManager.currentTimeMillis();
+ createTable(dataTableName);
+ //increment by 10 min to make sure we don't "look back" past table
creation
+ injectEdge.incValue(WAIT_AFTER_TABLE_CREATION);
+ populateTable(dataTableName);
+ injectEdge.incValue(1); //increment by 1 so we can see our write
+ long afterInsertSCN = EnvironmentEdgeManager.currentTimeMillis();
//make sure table and index metadata is set up right for versions
TableName dataTable = TableName.valueOf(dataTableName);
assertTableHasVersions(conn, dataTable, versions);
- String fullIndexName = indexStem + "1";
- TableName indexTable = TableName.valueOf(fullIndexName);
Review comment:
I suggest including indexes back and applying the same operations/checks to
the index tables along with their data tables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
