joshelser commented on a change in pull request #687: Hbase compat buildtime
URL: https://github.com/apache/phoenix/pull/687#discussion_r370763066
##########
File path: phoenix-assembly/pom.xml
##########
@@ -81,7 +81,7 @@
<goal>single</goal>
</goals>
<configuration>
- <finalName>phoenix-${project.version}</finalName>
+
<finalName>phoenix-${project.version}-Hbase-${hbase.compat.version}</finalName>
Review comment:
nit: 'hbase' or 'HBase'. I would say 'hbase' since we have 'phoenix'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
