joshelser commented on a change in pull request #687: Hbase compat buildtime
URL: https://github.com/apache/phoenix/pull/687#discussion_r370809824
##########
File path: pom.xml
##########
@@ -1031,6 +1054,42 @@
</plugins>
</build>
</profile>
+ <!-- Choose which hbase compatibility module we compile, test, and shade
against.
+ Shouldn't have an effect on the generated code and artifacts apart from
the contents of the the shaded jars
+ When specifying a non-default compatibility module, you also have to
specify a
+ compatible hbase.version i.e mvn clean install -P phoenix-hbase-compat-2.2
-Dhbase.version=2.2.3
+ -->
+ <profile>
+ <id>phoenix-hbase-compat-2.0</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
Talked to Busbey about this because I figured he would be the only other
Maven guru I know who remembers this. He pointed me back to
https://issues.apache.org/jira/browse/MNG-4917
The question is why, when I specified a profile, did I not see these
semantics? Sounds like https://issues.apache.org/jira/browse/MNG-6787 might be
affecting my 3.6.3 Maven version.
I do think this needs to be changed from 2 profiles activating 2 states to 3
profiles activating 2 states (as dumb as that is):
* profile1 activated by `! hbase.compat.version` which selects the hbase 2.0
compat module
* profile 2 activated by `hbase.compat.version=2.0` which selects the hbase
2.0 compat module
* profile 3 activated by `hbase.compat.version=2.2` which selects the hbase
2.2 compat module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
