stoty commented on a change in pull request #687: Hbase compat buildtime
URL: https://github.com/apache/phoenix/pull/687#discussion_r370810929
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
##########
@@ -464,12 +464,14 @@ public void
preIndexUpdate(ObserverContext<PhoenixMetaDataControllerEnvironment>
return userPermissions;
}
+ //FIXME This seems to have no effect at all
private void getUserDefinedPermissions(final TableName tableName,
final List<UserPermission> userPermissions) throws IOException {
User.runAsLoginUser(new
PrivilegedExceptionAction<List<UserPermission>>() {
@Override
public List<UserPermission> run() throws Exception {
- final List<UserPermission> userPermissions = new
ArrayList<UserPermission>();
+ //FIXME We are masking the parameter list that we are
supposed to add to
Review comment:
Yes, I don't want fix unrelated bugs in this commit, to make testing easier.
Also, writing a test case for this promises to be quite hairy, which is
another reason not to tackle this right now.
I'll make a separate ticket for this as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
