stoty commented on a change in pull request #687: Hbase compat buildtime
URL: https://github.com/apache/phoenix/pull/687#discussion_r371666283
##########
File path: pom.xml
##########
@@ -1031,6 +1049,55 @@
</plugins>
</build>
</profile>
+ <!--
+ Do not specify the compatibility profiles directly, set
hbase.compat.version instead.
+ e.g. mvn clean install -Dhbase.compat.version=2.2.1
+ -->
+ <profile>
+ <id>phoenix-hbase-compat-2.0.1-default</id>
+ <activation>
+ <property>
+ <name>!hbase.compat.version</name>
+ </property>
+ </activation>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-hbase-compat-2.0.1</artifactId>
+ </dependency>
+ </dependencies>
+ </profile>
+ <profile>
+ <id>phoenix-hbase-compat-2.0.1</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ <property>
+ <name>hbase.compat.version</name>
+ <value>2.0.1</value>
+ </property>
+ </activation>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-hbase-compat-2.0.1</artifactId>
+ </dependency>
+ </dependencies>
+ </profile>
+ <profile>
+ <id>phoenix-hbase-compat-2.2.1</id>
+ <activation>
+ <property>
+ <name>hbase.compat.version</name>
+ <value>2.2.1</value>
Review comment:
I've just run some quick tests, the 2.0.1 compatibility module (and
consequently, the current master branch) in fact only compiles with HBase 2.0.1
- 2.0.4 and 2.1.0 - 2.1.2. Maybe adding a module for current 2.0 versions would
be useful as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
