stoty commented on a change in pull request #687: Hbase compat buildtime
URL: https://github.com/apache/phoenix/pull/687#discussion_r370837223
##########
File path: pom.xml
##########
@@ -1031,6 +1054,42 @@
</plugins>
</build>
</profile>
+ <!-- Choose which hbase compatibility module we compile, test, and shade
against.
+ Shouldn't have an effect on the generated code and artifacts apart from
the contents of the the shaded jars
+ When specifying a non-default compatibility module, you also have to
specify a
+ compatible hbase.version i.e mvn clean install -P phoenix-hbase-compat-2.2
-Dhbase.version=2.2.3
Review comment:
It already works that way, we always build and install both modules (maven
artifacts)
However, I haven't thought of the /lib dir in the assembly, and the compat
dependency doesn't get added automatically. I have fixed that now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
