stoty commented on a change in pull request #687: Hbase compat buildtime
URL: https://github.com/apache/phoenix/pull/687#discussion_r370824081
##########
File path: pom.xml
##########
@@ -1031,6 +1054,42 @@
</plugins>
</build>
</profile>
+ <!-- Choose which hbase compatibility module we compile, test, and shade
against.
+ Shouldn't have an effect on the generated code and artifacts apart from
the contents of the the shaded jars
+ When specifying a non-default compatibility module, you also have to
specify a
+ compatible hbase.version i.e mvn clean install -P phoenix-hbase-compat-2.2
-Dhbase.version=2.2.3
+ -->
+ <profile>
+ <id>phoenix-hbase-compat-2.0</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
Review comment:
Right now I am using `hbase.compat.version` for two things
- selecting the right profile
- building the filenames and classifiers.
So the build is not designed to work correctly if you directly specify the
profile.
We could probably make that work, but we'd have to push down profile
handling to each module and set the filenames/classifiers directly, which would
be rather ugly.
Actually, MNG-6787 even helps us, as it means that you we can specify other
profiles (namely release), and still get the implicit 2.0.1 profile as well.
However, to make behaviour more consistent with a future maven release where
MNG-6787 is fixed, I agree that adding a third entry is the best option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
