sguggilam commented on a change in pull request #676: PHOENIX-5636: Improve the
error message when client connects to server with higher major version
URL: https://github.com/apache/phoenix/pull/676#discussion_r373292196
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1571,15 +1576,28 @@ public GetVersionResponse call(MetaDataService
instance)
}
}
}
- if (isIncompatible) {
- buf.setLength(buf.length()-1);
- throw new
SQLExceptionInfo.Builder(SQLExceptionCode.OUTDATED_JARS).setMessage(buf.toString()).build().buildException();
+ if (!(errorCode.toString().equals(new StringBuilder().toString()))) {
Review comment:
is this doing an empty string comparision ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
