ChinmaySKulkarni commented on a change in pull request #676: PHOENIX-5636:
Improve the error message when client connects to server with higher major
version
URL: https://github.com/apache/phoenix/pull/676#discussion_r377859790
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1487,20 +1487,17 @@ private static boolean hasIndexWALCodec(Long
serverVersion) {
return MetaDataUtil.decodeHasIndexWALCodec(serverVersion);
}
- private static boolean isCompatible(Long serverVersion) {
+ private static boolean isCompatible(Long serverVersion, StringBuilder buf)
{
Review comment:
This might be out of scope of your JIRA, but it's a potentially small
change. The method `isCompatible` looks pretty useless to me. Can't all the
logic be moved down to `MetaDataUtil.areClientAndServerCompatible`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
