ChinmaySKulkarni commented on a change in pull request #676: PHOENIX-5636:
Improve the error message when client connects to server with higher major
version
URL: https://github.com/apache/phoenix/pull/676#discussion_r383455100
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1588,15 +1596,19 @@ public GetVersionResponse call(MetaDataService
instance)
}
}
}
- if (isIncompatible) {
- buf.setLength(buf.length()-1);
- throw new
SQLExceptionInfo.Builder(SQLExceptionCode.OUTDATED_JARS).setMessage(buf.toString()).build().buildException();
- }
+
if (systemCatalogTimestamp < MIN_SYSTEM_TABLE_TIMESTAMP) {
throw new UpgradeRequiredException(systemCatalogTimestamp);
}
}
+ private String getClientandServerVersions(long serverJarVersion) {
Review comment:
I guess this method can just be `getServerVersion` right? Since the client
version is basically `MetaDataProtocol.CURRENT_CLIENT_VERSION`. That way,
you're also not making it mandatory for this info to be returned as a string
"Client version ... ".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
