ChinmaySKulkarni commented on a change in pull request #676: PHOENIX-5636:
Improve the error message when client connects to server with higher major
version
URL: https://github.com/apache/phoenix/pull/676#discussion_r385400277
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java
##########
@@ -122,7 +124,36 @@
ColumnFamilyDescriptorBuilder.KEEP_DELETED_CELLS,
ColumnFamilyDescriptorBuilder.REPLICATION_SCOPE);
- public static boolean areClientAndServerCompatible(long
serverHBaseAndPhoenixVersion) {
+ public static class ClientServerCompatibility {
+
+ long serverVersion;
+ int errorCode;
+ boolean isCompatible;
+
+ ClientServerCompatibility(long serverVersion) {
+ this.serverVersion = serverVersion;
+ this.errorCode = 0;
+ this.isCompatible = true;
Review comment:
Why is this true by default? I think it's safer for it to default to false
(you don't have to assign it since primitive boolean defaults to false).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
