ChinmaySKulkarni commented on a change in pull request #676: PHOENIX-5636:
Improve the error message when client connects to server with higher major
version
URL: https://github.com/apache/phoenix/pull/676#discussion_r385443724
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1570,6 +1575,15 @@ public GetVersionResponse call(MetaDataService instance)
systemCatalogTimestamp = systemCatalogTimestamp <
versionResponse.getSystemCatalogTimestamp() ?
systemCatalogTimestamp:
versionResponse.getSystemCatalogTimestamp();
}
+
+ if (compatibility.getErrorCode() != 0) {
+ if (compatibility.getErrorCode() ==
SQLExceptionCode.OUTDATED_JARS.getErrorCode()) {
+ errorMessage.setLength(errorMessage.length()-1);
Review comment:
If there aren't multiple messages, and the loop runs just once, does it
print the correct thing still or leave out the last character?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
