[
https://issues.apache.org/jira/browse/PHOENIX-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057582#comment-17057582
]
Hadoop QA commented on PHOENIX-5732:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12996481/PHOENIX-5732.4.x.v1.patch
against 4.x branch at commit c69f78f124ef0d248a4106c374cbf631ab0b3be0.
ATTACHMENT ID: 12996481
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ IndexTool.IndexVerifyType
verifyType, Long startTime, Long endTime) {
+ List<String> args = getArgList(directApi, useSnapshot, schemaName,
dataTable, indexTable, tenantId, verifyType, null, null);
+ String dataTable, String indexTable, String tenantId,
IndexTool.IndexVerifyType verifyType, long startTime, long endTime) {
+ List<String> args = getArgList(directApi, useSnapshot, schemaName,
dataTable, indexTable, tenantId, verifyType, startTime, endTime);
+ private static final Option START_TIME_OPTION = new Option("st",
"starttime", true, "Start time for indextool rebuild or verify");
+ private static final Option END_TIME_OPTION = new Option("et", "endtime",
true, "End time for indextool rebuild or verify");
+ if (cmdLine.hasOption(PARTIAL_REBUILD_OPTION.getOpt()) &&
cmdLine.hasOption(INDEX_TABLE_OPTION.getOpt())) {
+ throw new IllegalStateException("Index name should not be passed
with " + PARTIAL_REBUILD_OPTION.getLongOpt());
+ if (cmdLine.hasOption(PARTIAL_REBUILD_OPTION.getOpt()) &&
cmdLine.hasOption(DELETE_ALL_AND_REBUILD_OPTION.getOpt())) {
+ " %s is not an index table for %s for this connection",
indexTable, qDataTable));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolTimeRangeIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3577//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3577//console
This message is automatically generated.
> Implement starttime, endtime in IndexTool for rebuild and verification
> ----------------------------------------------------------------------
>
> Key: PHOENIX-5732
> URL: https://issues.apache.org/jira/browse/PHOENIX-5732
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Major
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5732.4.x.v1.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> IndexTool's inline verification and rebuild should be able to perform the
> logic for a specified time range given by starttime and endtime parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
