[ 
https://issues.apache.org/jira/browse/PHOENIX-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059953#comment-17059953
 ] 

Hadoop QA commented on PHOENIX-5732:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12996795/PHOENIX-5732.4.x.v3.patch
  against 4.x branch at commit 981aa7bbd1ca01cb5607aa74b541403c3dd89135.
  ATTACHMENT ID: 12996795

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 17 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        if (cmdLine.hasOption(PARTIAL_REBUILD_OPTION.getOpt()) && 
cmdLine.hasOption(DELETE_ALL_AND_REBUILD_OPTION.getOpt())) {
+        if (st.compareTo(currentTime) > 0 || et.compareTo(currentTime) > 0 || 
st.compareTo(et) >= 0) {
+        pIndexTable = PhoenixRuntime.getTable(connection, schemaName != null 
&& !schemaName.isEmpty()
+        // We have to mark Disable index to Building before we can set it to 
Active in the reducer. Otherwise it errors out with
+            int autosplitNumRegions = nOpt == null ? 
DEFAULT_AUTOSPLIT_NUM_REGIONS : Integer.parseInt(nOpt);
+            double samplingRate = rateOpt == null ? 
DEFAULT_SPLIT_SAMPLING_RATE : Double.parseDouble(rateOpt);

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3591//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3591//console

This message is automatically generated.

> Implement starttime, endtime in IndexTool for rebuild and verification
> ----------------------------------------------------------------------
>
>                 Key: PHOENIX-5732
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5732
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Major
>             Fix For: 5.1.0, 4.15.1
>
>         Attachments: PHOENIX-5732.4.x.v1.patch, PHOENIX-5732.4.x.v2.patch, 
> PHOENIX-5732.4.x.v3.patch
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> IndexTool's inline verification and rebuild should be able to perform the 
> logic for a specified time range given by starttime and endtime parameters. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to