[
https://issues.apache.org/jira/browse/PHOENIX-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061277#comment-17061277
]
Hadoop QA commented on PHOENIX-5732:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12996963/PHOENIX-5732.4.x.v4.patch
against 4.x branch at commit 2d88e786eb80fa5c1d9e74c55c6d0c464738c4f2.
ATTACHMENT ID: 12996963
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 18 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if (cmdLine.hasOption(PARTIAL_REBUILD_OPTION.getOpt()) &&
cmdLine.hasOption(DELETE_ALL_AND_REBUILD_OPTION.getOpt())) {
+ // However, PHOENIX-5732 introduces endTime parameter to
be passed optionally for IndexTool.
+ // When endTime is passed for local and non-tx global
indexes, we'll override the CURRENT_SCN_VALUE.
+ public static void checkTimeRangeFeature(Long startTime, Long endTime,
PTable pDataTable, boolean isLocalIndexBuild) {
+ if (isTimeRangeSet(startTime, endTime) &&
!isTimeRangeFeatureApplicable(pDataTable, isLocalIndexBuild)) {
+ if (st.compareTo(currentTime) > 0 || et.compareTo(currentTime) > 0 ||
st.compareTo(et) >= 0) {
+ pIndexTable = PhoenixRuntime.getTable(connection, schemaName != null
&& !schemaName.isEmpty()
+ // We have to mark Disable index to Building before we can set it to
Active in the reducer. Otherwise it errors out with
+ private static boolean isTimeRangeFeatureApplicable(PTable dataTable,
boolean isLocalIndexBuild) {
+ int autosplitNumRegions = nOpt == null ?
DEFAULT_AUTOSPLIT_NUM_REGIONS : Integer.parseInt(nOpt);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3603//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3603//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3603//console
This message is automatically generated.
> Implement starttime, endtime in IndexTool for rebuild and verification
> ----------------------------------------------------------------------
>
> Key: PHOENIX-5732
> URL: https://issues.apache.org/jira/browse/PHOENIX-5732
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Major
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5732.4.x.v1.patch, PHOENIX-5732.4.x.v2.patch,
> PHOENIX-5732.4.x.v3.patch, PHOENIX-5732.4.x.v4.patch
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> IndexTool's inline verification and rebuild should be able to perform the
> logic for a specified time range given by starttime and endtime parameters.
>
> This feature is only for indexes on non-transactional tables
> .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
