joshelser commented on a change in pull request #20: PHOENIX-5772 Streamline 
the kerberos logic in thin client java code
URL: https://github.com/apache/phoenix-queryserver/pull/20#discussion_r391831456
 
 

 ##########
 File path: bin/thin_client_jaas.conf
 ##########
 @@ -0,0 +1,5 @@
+ThinClient {
 
 Review comment:
   Maybe make this PhoenixThinClient? Disambiguate from other products who have 
JAAS config names.
   
   e.g. ZooKeeper uses a generic name like "Client" or something equally 
annoying and likely to conflict with other systems :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to