stoty commented on a change in pull request #20: PHOENIX-5772 Streamline the
kerberos logic in thin client java code
URL: https://github.com/apache/phoenix-queryserver/pull/20#discussion_r392210686
##########
File path: bin/sqlline-thin.py
##########
@@ -164,15 +181,34 @@ def get_serialization():
jdbc_url += ';avatica_user=' + args.auth_user
if args.auth_password:
jdbc_url += ';avatica_password=' + args.auth_password
+if args.principal:
Review comment:
In theory we should. But then we should also parse the passed-in URL, and do
something with the conflicts between that and the cli options, and I did not
want to go that deep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
