joshelser commented on a change in pull request #20: PHOENIX-5772 Streamline
the kerberos logic in thin client java code
URL: https://github.com/apache/phoenix-queryserver/pull/20#discussion_r391828035
##########
File path: bin/sqlline-thin.py
##########
@@ -164,15 +181,34 @@ def get_serialization():
jdbc_url += ';avatica_user=' + args.auth_user
if args.auth_password:
jdbc_url += ';avatica_password=' + args.auth_password
+if args.principal:
+ jdbc_url += ';principal=' + args.principal
+if args.keytab:
+ jdbc_url += ';keytab=' + args.keytab
if args.truststore:
jdbc_url += ';truststore=' + args.truststore
if args.truststore_password:
jdbc_url += ';truststore_password=' + args.truststore_password
+
+# Add SPENGO auth if this cluster uses it, and there are no conflicting HBase
parameters
+if (get_hbase_authentication() == 'kerberos' and get_spnego_auth_disabled() ==
'false'
+ and 'authentication=' not in jdbc_url and 'avatica_user=' not in jdbc_url):
+ # For some bizarre reason Avatica doesn't seem to accept authentication as
the last parameter
Review comment:
That sounds like a super fun bug :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
