wangweiming800 commented on a change in pull request #741: PHOENIX-5791
Eliminate false invalid row detection due to concurrent …
URL: https://github.com/apache/phoenix/pull/741#discussion_r397551472
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -614,38 +606,132 @@ private boolean isDeleteFamilyVersion(Mutation
mutation) {
return getMutationsWithSameTS(put, del);
}
+ private void repairActualMutationList(List<Mutation> actualMutationList,
List<Mutation> expectedMutationList)
Review comment:
I am just thinking aloud here. Read repair has similar logic to generate the
expected index mutation, but only for specific timestamp. Is it possible to
leverage the code there or unify them?
One side question. From the code of repairIndexRows, it looks like opening a
lot of scan. If there are multiple concurrent read repair happen (may be caused
by some bug int the future or network issue), will it overload the hbase region
server and cause the cluster not be able to recover from such network hiccup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
