kadirozde commented on a change in pull request #741: PHOENIX-5791 Eliminate false invalid row detection due to concurrent … URL: https://github.com/apache/phoenix/pull/741#discussion_r398228255
########## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ########## @@ -614,38 +606,132 @@ private boolean isDeleteFamilyVersion(Mutation mutation) { return getMutationsWithSameTS(put, del); } + private void repairActualMutationList(List<Mutation> actualMutationList, List<Mutation> expectedMutationList) + throws IOException { + // find the first (latest) actual unverified put mutation + Mutation actual = null; + for (Mutation mutation : actualMutationList) { + if (mutation instanceof Put && !isVerified((Put) mutation)) { + actual = mutation; + break; + } + } + if (actual == null) { + return; + } + long ts = getTimestamp(actual); + int expectedIndex; + int expectedListSize = expectedMutationList.size(); + for (expectedIndex = 0; expectedIndex < expectedListSize; expectedIndex++) { + if (getTimestamp(expectedMutationList.get(expectedIndex)) <= ts) { + if (expectedIndex > 0) { + expectedIndex--; + } + break; + } + } + if (expectedIndex == expectedListSize) { + return; + } + for (; expectedIndex < expectedListSize; expectedIndex++) { + Mutation mutation = expectedMutationList.get(expectedIndex); + if (mutation instanceof Put) { + mutation = new Put((Put) mutation); + } else { + mutation = new Delete((Delete) mutation); + } + actualMutationList.add(mutation); + } + Collections.sort(actualMutationList, MUTATION_TS_DESC_COMPARATOR); + } + + private void cleanUpActualMutationList(List<Mutation> actualMutationList) Review comment: @wangweiming800, Please see the updated the code above and let me know if you have a question on this ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services