kadirozde commented on a change in pull request #741: PHOENIX-5791 Eliminate
false invalid row detection due to concurrent …
URL: https://github.com/apache/phoenix/pull/741#discussion_r398227615
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -614,38 +606,132 @@ private boolean isDeleteFamilyVersion(Mutation
mutation) {
return getMutationsWithSameTS(put, del);
}
+ private void repairActualMutationList(List<Mutation> actualMutationList,
List<Mutation> expectedMutationList)
Review comment:
This simulates the read repair given that the list of revisions for the
actual and the expected (repaired form) mutations. It is much simpler than the
read repair process in GlobalIndexChecker which works on one index row at a
time and leverages the HBase scans on the actual table, which is not the case
here. Also, GlobalIndexChecker also purges the invalid rows from HBase in
addition rebuilding unverified rows. So, they are very different in nature and
not sure how they can be unified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
