gokceni commented on a change in pull request #743: PHOENIX-5798 IndexUpgrade
tool command line improvements
URL: https://github.com/apache/phoenix/pull/743#discussion_r397989831
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java
##########
@@ -298,20 +299,22 @@ private void checkOldIndexingCoprocessors(String []
indexList, String [] tableLi
}
}
- @Parameters(name
="IndexUpgradeToolIT_mutable={0},upgrade={1},isNamespaceEnabled={2}")
+ @Parameters(name
="IndexUpgradeToolIT_mutable={0},upgrade={1},isNamespaceEnabled={2},
rebuild={3}")
public static synchronized Collection<Object[]> data() {
return Arrays.asList(new Object[][] {
- {false, false, true},
- {true, false, false},
- {false, true, false},
- {true, true, true}
+ {false, false, true, false},
Review comment:
Don't you want to test false, false, true, true and
true, false, false, false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
