swaroopak commented on a change in pull request #743: PHOENIX-5798 IndexUpgrade
tool command line improvements
URL: https://github.com/apache/phoenix/pull/743#discussion_r398122180
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -707,12 +716,12 @@ private int startIndexRebuilds(HashMap<String,
IndexInfo> indexInfos,
list.add("-tenant");
list.add(tenantId);
}
- if (syncRebuild) {
- list.add("-runfg");
- }
- if(!Strings.isNullOrEmpty(verify)) {
- list.add("-v");
- list.add(verify);
+
+ if(!Strings.isNullOrEmpty(indexToolOpts)) {
+ String[] options = indexToolOpts.split("\\s+");
Review comment:
should be fine, but good to double-check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
