swaroopak commented on a change in pull request #743: PHOENIX-5798 IndexUpgrade tool command line improvements URL: https://github.com/apache/phoenix/pull/743#discussion_r398107999
########## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java ########## @@ -577,6 +582,10 @@ private void rebuildIndexes(Connection conn, Configuration conf, ArrayList<Strin if (!upgrade) { return; } + if (!rebuild) { Review comment: better to combine in one` if`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services