gjacoby126 commented on a change in pull request #751: PHOENIX-5735 Add the
maxLookBack logic in the inline validation.
URL: https://github.com/apache/phoenix/pull/751#discussion_r402652352
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -822,7 +861,8 @@ public boolean verifySingleIndexRow(Result indexRow,
IndexToolVerificationResult
if (previousExpected instanceof Delete) {
// Between an expected delete and put, there can be one or
more deletes due to
// concurrent mutations or data table write failures. Skip
all of them if any
- while (getTimestamp(actual) > getTimestamp(expected) &&
(actual instanceof Delete)) {
+ // There cannot be any actual delete mutation between two
expected put mutations.
+ while (getTimestamp(actual) >= getTimestamp(expected) &&
actual instanceof Delete) {
Review comment:
good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
