gjacoby126 commented on a change in pull request #751: PHOENIX-5735 Add the
maxLookBack logic in the inline validation.
URL: https://github.com/apache/phoenix/pull/751#discussion_r402651153
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java
##########
@@ -593,9 +595,19 @@ public void testIndexToolVerifyAfterOption() throws
Exception {
null, -1, IndexTool.IndexVerifyType.AFTER);
// The index tool output table should report that there is a
missing index row
Cell cell = getErrorMessageFromIndexToolOutputTable(conn,
dataTableFullName, "_IDX_" + dataTableFullName);
+ try {
+ String expectedErrorMsg = "Missing index row beyond
maxLookBack";
+ String actualErrorMsg = Bytes.toString(cell.getValueArray(),
cell.getValueOffset(), cell.getValueLength());
+ assertTrue(expectedErrorMsg.equals(actualErrorMsg));
+ }catch(Exception ex){
+ Assert.fail("Fail to parsing the error message from
IndexToolOutputTable");
+ }
+ /*
Review comment:
Please remove rather than commenting out unneeded code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
