swaroopak commented on a change in pull request #751: PHOENIX-5735 Add the
maxLookBack logic in the inline validation.
URL: https://github.com/apache/phoenix/pull/751#discussion_r403405169
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java
##########
@@ -593,9 +595,13 @@ public void testIndexToolVerifyAfterOption() throws
Exception {
null, -1, IndexTool.IndexVerifyType.AFTER);
// The index tool output table should report that there is a
missing index row
Cell cell = getErrorMessageFromIndexToolOutputTable(conn,
dataTableFullName, "_IDX_" + dataTableFullName);
- byte[] expectedValueBytes = Bytes.toBytes("Missing index row");
- assertTrue(Bytes.compareTo(cell.getValueArray(),
cell.getValueOffset(), cell.getValueLength(),
- expectedValueBytes, 0, expectedValueBytes.length) == 0);
+ try {
+ String expectedErrorMsg =
IndexRebuildRegionScanner.ERROR_MESSAGE_MISSING_INDEX_ROW_BEYOND_MAX_LOOKBACK;
+ String actualErrorMsg = Bytes.toString(cell.getValueArray(),
cell.getValueOffset(), cell.getValueLength());
+ assertTrue(expectedErrorMsg.equals(actualErrorMsg));
+ }catch(Exception ex){
Review comment:
nit: space around catch block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
