ChinmaySKulkarni commented on a change in pull request #749: PHOENIX-4521:
Allow Pherf scenario to define per query max allowed query execution duration
after which thread is interrupted
URL: https://github.com/apache/phoenix/pull/749#discussion_r402655375
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedDifferTest.java
##########
@@ -0,0 +1,51 @@
+package org.apache.phoenix.pherf.workload;
+
+import javafx.util.Pair;
+import org.apache.phoenix.pherf.configuration.Query;
+import org.apache.phoenix.pherf.configuration.Scenario;
+import org.apache.phoenix.pherf.configuration.XMLConfigParser;
+import org.apache.phoenix.pherf.result.DataModelResult;
+import org.apache.phoenix.pherf.result.ThreadTime;
+import org.apache.phoenix.pherf.rules.RulesApplier;
+import org.apache.phoenix.util.EnvironmentEdge;
+import org.apache.phoenix.util.EnvironmentEdgeManager;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import java.sql.ResultSet;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+public class MultiThreadedDifferTest {
+
+ private static class MyClock extends EnvironmentEdge {
+
+ public MyClock () {}
+
+ @Override
+ public long currentTime() {
+ return System.currentTimeMillis();
+ }
+ }
+
+ @Test
+ public void testTimeout() throws Exception {
+ MyClock myClock = Mockito.mock(MyClock.class);
+ Mockito.when(myClock.currentTime()).thenReturn(0L,5000L);
//currentTime() gets called twice during MTR construction
+ EnvironmentEdgeManager.injectEdge(myClock);
+ MultithreadedDiffer mtd = new MultithreadedDiffer("test", new Query(),
new ThreadTime(),
+ 10, 1000);
Review comment:
Can you make these 10L and 1000L to indicate they are long type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
