ChinmaySKulkarni commented on a change in pull request #749: PHOENIX-4521:
Allow Pherf scenario to define per query max allowed query execution duration
after which thread is interrupted
URL: https://github.com/apache/phoenix/pull/749#discussion_r402662082
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java
##########
@@ -0,0 +1,95 @@
+package org.apache.phoenix.pherf.workload;
+
+import javafx.util.Pair;
+import org.apache.phoenix.pherf.configuration.Query;
+import org.apache.phoenix.pherf.configuration.Scenario;
+import org.apache.phoenix.pherf.configuration.XMLConfigParser;
+import org.apache.phoenix.pherf.result.DataModelResult;
+import org.apache.phoenix.pherf.result.ThreadTime;
+import org.apache.phoenix.pherf.rules.RulesApplier;
+import org.apache.phoenix.util.EnvironmentEdge;
+import org.apache.phoenix.util.EnvironmentEdgeManager;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import java.sql.ResultSet;
+
+import static org.junit.Assert.*;
+
+public class MultiThreadedRunnerTest {
+
+ private static class MyClock extends EnvironmentEdge {
+
+ public MyClock () {}
+
+ @Override
+ public long currentTime() {
+ return System.currentTimeMillis();
+ }
+ }
+
+ @Test
+ public void testExpectedRowsMismatch() throws Exception {
+ XMLConfigParser parser = new
XMLConfigParser(".*timeout_test_scenario.xml");
Review comment:
Why not mock all of these too and create the `MultiThreadedRunner` object
using those mocks? I don't think any of these are really relevant for/used
inside `getResults` anyways, so you potentially wouldn't even need to stub
methods for them. Doing this will make your tests cleaner and easier to
understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
