ChinmaySKulkarni commented on a change in pull request #749: PHOENIX-4521: 
Allow Pherf scenario to define per query max allowed query execution duration 
after which thread is interrupted
URL: https://github.com/apache/phoenix/pull/749#discussion_r402658624
 
 

 ##########
 File path: 
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedDiffer.java
 ##########
 @@ -49,8 +50,10 @@ private synchronized ThreadTime getThreadTime() {
      * Query Verification
      *
      * @throws Exception
+     * @returns boolean true if query timed out; false otherwise
 
 Review comment:
   `timedQuery` returns true if there is no timeout (expected). Let's make this 
method consistent with that one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to