christinefeng commented on a change in pull request #749: PHOENIX-4521: Allow
Pherf scenario to define per query max allowed query execution duration after
which thread is interrupted
URL: https://github.com/apache/phoenix/pull/749#discussion_r402665993
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/QueryResult.java
##########
@@ -150,6 +151,7 @@ private long getResultRowCount() {
List<ResultValue> rowValues = new ArrayList<>();
rowValues.add(new
ResultValue(util.convertNull(getStartTimeText())));
rowValues.add(new
ResultValue(util.convertNull(this.getQueryGroup())));
+ rowValues.add(new ResultValue(util.convertNull(this.getId())));
Review comment:
This allows me to verify the results for each query, since all executions of
query q1 are supposed to fail and all of the ones for q2 and q3 are supposed to
succeed
Since my test queries are all in one scenario file now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services